D19854: Use single-argument constructor of WebEngineViewer::WebEnginePage

Laurent Montel noreply at phabricator.kde.org
Wed Mar 20 06:51:39 GMT 2019


mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> articleviewerwebenginepage.h:30
> +    explicit ArticleViewerWebEnginePage(QObject *parent = nullptr);
> +    virtual ~ArticleViewerWebEnginePage() override;
>  

Why virtual ? we have override for it no ?

REPOSITORY
  R201 Akregator

REVISION DETAIL
  https://phabricator.kde.org/D19854

To: marten, #kde_pim, mlaurent
Cc: mlaurent, kde-pim, dvasin, rodsevich, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190320/75414cc6/attachment.html>


More information about the kde-pim mailing list