D19854: Use single-argument constructor of WebEngineViewer::WebEnginePage

Jonathan Marten noreply at phabricator.kde.org
Mon Mar 18 14:25:38 GMT 2019


marten created this revision.
marten added a reviewer: KDE PIM.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
marten requested review of this revision.

REVISION SUMMARY
  The two-argument constructor for that, where a QWebEngineProfile is provided, was deprecated by D19559 <https://phabricator.kde.org/D19559>.  This changes ArticleViewerWebEngine to use the single-argument constructor, which creates a private profile and handles the management of it.

TEST PLAN
  Built Akregator with this change, observed correct viewing and opening of articles in tabs and inline.

REPOSITORY
  R201 Akregator

REVISION DETAIL
  https://phabricator.kde.org/D19854

AFFECTED FILES
  src/articleviewer-ng/webengine/articleviewerwebengine.cpp
  src/articleviewer-ng/webengine/articleviewerwebenginepage.cpp
  src/articleviewer-ng/webengine/articleviewerwebenginepage.h

To: marten, #kde_pim
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190318/e9828179/attachment.html>


More information about the kde-pim mailing list