D15727: Prepare environment to be able to test grantleeheaderstyle.

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  No ECM foo for local copying, so this CMakeLists.txt looks fine to me.

INLINE COMMENTS

> grantleeheaderstyleplugintest.cpp:41
> +    qputenv("LC_ALL", "C");
> +    qputenv("KDEHOME", QFile::encodeName(QDir::homePath() + QString::fromLatin1("/.qttest")).constData());
> +    qputenv("XDG_DATA_HOME", QFile::encodeName(QCoreApplication::applicationDirPath() + QString::fromLatin1("/share")).constData());

KDEHOME? This isn't 2011 anymore. Nothing uses KDEHOME anymore, you can remove that.

QStandardPaths::setTestModeEnabled(true); would be a better thing to call here instead.

> grantleeheaderstyleplugintest.cpp:42
> +    qputenv("KDEHOME", QFile::encodeName(QDir::homePath() + QString::fromLatin1("/.qttest")).constData());
> +    qputenv("XDG_DATA_HOME", QFile::encodeName(QCoreApplication::applicationDirPath() + QString::fromLatin1("/share")).constData());
> +}

Note that this will have no effect on Windows, so for now you'll have to skip anything that relies on this, if Q_OS_WIN.

A proper fix (QT_DATA_DIRS) is coming soon hopefully.

> grantleeheaderstyleplugintest.cpp:73
> +
> +    qDebug() << interface->mThemeManager->themes().keys();
> +

No way to QCOMPARE that?

Right now this method looks suspiciously like the previous one...

REPOSITORY
  R81 KDE PIM Addons

REVISION DETAIL
  https://phabricator.kde.org/D15727

To: knauss, dfaure, #kde_pim
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181004/67876657/attachment.html>