<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15727">View Revision</a></tr></table><br /><div><div><p>No ECM foo for local copying, so this CMakeLists.txt looks fine to me.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15727#inline-86248">View Inline</a><span style="color: #4b4d51; font-weight: bold;">grantleeheaderstyleplugintest.cpp:41</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">qputenv</span><span class="p">(</span><span style="color: #766510">"LC_ALL"</span><span class="p">,</span> <span style="color: #766510">"C"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">qputenv</span><span class="p">(</span><span style="color: #766510">"KDEHOME"</span><span class="p">,</span> <span class="n">QFile</span><span style="color: #aa2211">::</span><span class="n">encodeName</span><span class="p">(</span><span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">homePath</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">fromLatin1</span><span class="p">(</span><span style="color: #766510">"/.qttest"</span><span class="p">)).</span><span class="n">constData</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">qputenv</span><span class="p">(</span><span style="color: #766510">"XDG_DATA_HOME"</span><span class="p">,</span> <span class="n">QFile</span><span style="color: #aa2211">::</span><span class="n">encodeName</span><span class="p">(</span><span class="n">QCoreApplication</span><span style="color: #aa2211">::</span><span class="n">applicationDirPath</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">fromLatin1</span><span class="p">(</span><span style="color: #766510">"/share"</span><span class="p">)).</span><span class="n">constData</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">KDEHOME? This isn't 2011 anymore. Nothing uses KDEHOME anymore, you can remove that.</p>

<p style="padding: 0; margin: 8px;">QStandardPaths::setTestModeEnabled(true); would be a better thing to call here instead.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15727#inline-86250">View Inline</a><span style="color: #4b4d51; font-weight: bold;">grantleeheaderstyleplugintest.cpp:42</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">qputenv</span><span class="p">(</span><span style="color: #766510">"KDEHOME"</span><span class="p">,</span> <span class="n">QFile</span><span style="color: #aa2211">::</span><span class="n">encodeName</span><span class="p">(</span><span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">homePath</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">fromLatin1</span><span class="p">(</span><span style="color: #766510">"/.qttest"</span><span class="p">)).</span><span class="n">constData</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">qputenv</span><span class="p">(</span><span style="color: #766510">"XDG_DATA_HOME"</span><span class="p">,</span> <span class="n">QFile</span><span style="color: #aa2211">::</span><span class="n">encodeName</span><span class="p">(</span><span class="n">QCoreApplication</span><span style="color: #aa2211">::</span><span class="n">applicationDirPath</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">fromLatin1</span><span class="p">(</span><span style="color: #766510">"/share"</span><span class="p">)).</span><span class="n">constData</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Note that this will have no effect on Windows, so for now you'll have to skip anything that relies on this, if Q_OS_WIN.</p>

<p style="padding: 0; margin: 8px;">A proper fix (QT_DATA_DIRS) is coming soon hopefully.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15727#inline-86247">View Inline</a><span style="color: #4b4d51; font-weight: bold;">grantleeheaderstyleplugintest.cpp:73</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">qDebug</span><span class="p">()</span> <span style="color: #aa2211"><<</span> <span class="n">interface</span><span style="color: #aa2211">-></span><span class="n">mThemeManager</span><span style="color: #aa2211">-></span><span class="n">themes</span><span class="p">().</span><span class="n">keys</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">No way to QCOMPARE that?</p>

<p style="padding: 0; margin: 8px;">Right now this method looks suspiciously like the previous one...</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R81 KDE PIM Addons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15727">https://phabricator.kde.org/D15727</a></div></div><br /><div><strong>To: </strong>knauss, dfaure, KDE PIM<br /><strong>Cc: </strong>kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>