D15173: Add a new ISO 3166 code to country name mapping table

Volker Krause noreply at phabricator.kde.org
Fri Aug 31 08:38:55 BST 2018


vkrause added a comment.


  In D15173#318021 <https://phabricator.kde.org/D15173#318021>, @pino wrote:
  
  > I don't see how loading it once per process would be a big issue, compared to embedding data in the library.
  >  Also, the proposed approach here creates another kind of static data in the sources (`isotocountrymap_data.cpp`); considering it is not automatically generated, this means that it will be hardly updated by anyone, and happily rot in the sources. Just look at the existing `countrytransl.map`, for example.
  
  
  Ok, that's something we can change probably, I followed the reverse direction based on the giant CLDR dataset here too closely maybe. We could make iso-codes a hard build-time requirement and generate this file every time, to address this concern. The CI has it on all platforms but Windows already it seems. Would that be acceptable?

REPOSITORY
  R174 PIM: KContacts

REVISION DETAIL
  https://phabricator.kde.org/D15173

To: vkrause, mlaurent, pino
Cc: pino, mlaurent, svuorela, kde-pim, dvasin, rodsevich, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180831/05374d1c/attachment.html>


More information about the kde-pim mailing list