D15173: Add a new ISO 3166 code to country name mapping table

Pino Toscano noreply at phabricator.kde.org
Fri Aug 31 08:30:47 BST 2018


pino added a comment.


  I don't see how loading it once per process would be a big issue, compared to embedding data in the library.
  Also, the proposed approach here creates another kind of static data in the sources (`isotocountrymap_data.cpp`); considering it is not automatically generated, this means that it will be hardly updated by anyone, and happily rot in the sources. Just look at the existing `countrytransl.map`, for example.
  
  So all it matters here is performance? Sigh...

REPOSITORY
  R174 PIM: KContacts

REVISION DETAIL
  https://phabricator.kde.org/D15173

To: vkrause, mlaurent, pino
Cc: pino, mlaurent, svuorela, kde-pim, dvasin, rodsevich, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180831/2dc2dc4b/attachment.html>


More information about the kde-pim mailing list