D15173: Add a new ISO 3166 code to country name mapping table

Pino Toscano noreply at phabricator.kde.org
Fri Aug 31 09:03:17 BST 2018


pino resigned from this revision.
pino added a comment.
This revision is now accepted and ready to land.


  In D15173#318022 <https://phabricator.kde.org/D15173#318022>, @vkrause wrote:
  
  > We could make iso-codes a hard build-time requirement and generate this file every time, to address this concern. The CI has it on all platforms but Windows already it seems. Would that be acceptable?
  
  
  Considering what I said earlier, it should be easy to imagine what my reply is ("no").
  
  Also, D14163: Fix translation of country names <https://phabricator.kde.org/D14163> was committed even if I had concerns on it; hence, I'm not sure it is even worth to argue here...

REPOSITORY
  R174 PIM: KContacts

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15173

To: vkrause, mlaurent
Cc: pino, mlaurent, svuorela, kde-pim, dvasin, rodsevich, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180831/b68f14fe/attachment.html>


More information about the kde-pim mailing list