D15173: Add a new ISO 3166 code to country name mapping table

[Volker Krause]

vkrause added a comment.


  In D15173#318027 <https://phabricator.kde.org/D15173#318027>, @pino wrote:
  
  > In D15173#318022 <https://phabricator.kde.org/D15173#318022>, @vkrause wrote:
  >
  > > We could make iso-codes a hard build-time requirement and generate this file every time, to address this concern. The CI has it on all platforms but Windows already it seems. Would that be acceptable?
  >
  >
  > Considering what I said earlier, it should be easy to imagine what my reply is ("no").
  
  
  The price for runtime loading is:
  
  - ~36kb of JSON we need to (partly) keep in non-shared heap memory vs. ~2kb of shared read-only data
  - some one time parsing cost which is probably irrelevant on desktop, and probably cost us ~100ms on mobile
  - addtional deployment of the iso-codes data file, again irrelevant on Linux desktops, probably also on Windows, but needing extra care on Android for example (or qrc bundling). Failures in deployment result in no country names being displayed at all.
  
  The price for compiled-in data is (assuming we change this to be updated on each build):
  
  - we might be out of sync with translations for country name changes within a release cycle, country names would be shown in the old form and without translations in that case.
  
  Obviously we disagree on how to value those trade-offs, so how to we get to a decision here?
  
  > Also, D14163: Fix translation of country names <https://phabricator.kde.org/D14163> was committed even if I had concerns on it; hence, I'm not sure it is even worth to argue here...
  
  For the record, D14163 <https://phabricator.kde.org/D14163> was committed after 4+ weeks of inactivity from you in the discussion, with 2 people (besides me) speaking out in favor of the patch and it blocking D14563 <https://phabricator.kde.org/D14563> (which addressed the other direction of this, country to iso). Additionally this patch here is attempting to  address the remaining issues you pointed out in D14163 <https://phabricator.kde.org/D14163> by moving to the iso-codes dataset (even if we still disagree on how well it does that).
  
  In all of this, let's also not forget the 18.08 baseline, where we have no working country name translations and are ~15 years out of touch with reality, all of which at a user-noticeable performance cost. I think all these patches improved that situation considerably, but there might of course still be some room for perfection ;-)

REPOSITORY
  R174 PIM: KContacts

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15173

To: vkrause, mlaurent
Cc: pino, mlaurent, svuorela, kde-pim, dvasin, rodsevich, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180831/a5d323f1/attachment.html>