D8551: Probe attachment mimetypes ourselves when there's doubt

[Sandro Knauß]

knauss added inline comments.

INLINE COMMENTS

> objecttreeparser.cpp:197
> +MessagePartPtr ObjectTreeParser::processType(KMime::Content *node, ProcessResult &processResult, const QString &mimeType)
>  {
> +    const auto formatters = mSource->bodyPartFormatterFactory()->formattersForType(mimeType);

getting rid of "bool onlyOneMimePart"  is seperated patch (simple cleanup)

> objecttreeparser.cpp:270
> +                const auto file = mNodeHelper->writeNodeToTempFile(node);
> +                mimeType = Util::mimetype(file).name();
>              }

Do we really need to write the the content to file before getting the propper mimetype? isn't that possible with QTextStream?

REPOSITORY
  R94 PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D8551

To: vkrause
Cc: knauss, #kde_pim, dvasin, winterz, vkrause, mlaurent, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171030/293ab981/attachment.html>