<table><tr><td style="">knauss added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8551" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8551#inline-37133" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">objecttreeparser.cpp:197</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="n">MessagePartPtr</span> <span class="n">ObjectTreeParser</span><span style="color: #aa2211">::</span><span class="n">processType</span><span class="p">(</span><span class="n">KMime</span><span style="color: #aa2211">::</span><span class="n">Content</span> <span style="color: #aa2211">*</span><span class="n">node</span><span class="p">,</span> <span class="n">ProcessResult</span> <span style="color: #aa2211">&</span><span class="n">processResult</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">Q<span class="bright">ByteArray</span></span> <span style="color: #aa2211">&</span><span class="n">mimeType<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">bool</span></span><span class="bright"> </span><span class="n"><span class="bright">onlyOneMimePart</span></span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">MessagePartPtr</span> <span class="n">ObjectTreeParser</span><span style="color: #aa2211">::</span><span class="n">processType</span><span class="p">(</span><span class="n">KMime</span><span style="color: #aa2211">::</span><span class="n">Content</span> <span style="color: #aa2211">*</span><span class="n">node</span><span class="p">,</span> <span class="n">ProcessResult</span> <span style="color: #aa2211">&</span><span class="n">processResult</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">Q<span class="bright">String</span></span> <span style="color: #aa2211">&</span><span class="n">mimeType</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">formatters</span> <span style="color: #aa2211">=</span> <span class="n">mSource</span><span style="color: #aa2211">-></span><span class="n">bodyPartFormatterFactory</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">formattersForType</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">QString</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">fromUtf8</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">mimeType<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">formatters</span> <span style="color: #aa2211">=</span> <span class="n">mSource</span><span style="color: #aa2211">-></span><span class="n">bodyPartFormatterFactory</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">formattersForType</span><span class="p">(</span><span class="n">mimeType</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">getting rid of "bool onlyOneMimePart"  is seperated patch (simple cleanup)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8551#inline-37131" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">objecttreeparser.cpp:270</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">file</span> <span style="color: #aa2211">=</span> <span class="n">mNodeHelper</span><span style="color: #aa2211">-></span><span class="n">writeNodeToTempFile</span><span class="p">(</span><span class="n">node</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span class="n">mimeType</span> <span style="color: #aa2211">=</span> <span class="n">Util</span><span style="color: #aa2211">::</span><span class="n">mimetype</span><span class="p">(</span><span class="n">file</span><span class="p">).</span><span class="n">name</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Do we really need to write the the content to file before getting the propper mimetype? isn't that possible with QTextStream?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R94 PIM: Message Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8551" rel="noreferrer">https://phabricator.kde.org/D8551</a></div></div><br /><div><strong>To: </strong>vkrause<br /><strong>Cc: </strong>knauss, KDE PIM, dvasin, winterz, vkrause, mlaurent, dvratil<br /></div>