D6977: servertest: add NNTP support

[Laurent Montel]

mlaurent added inline comments.

INLINE COMMENTS

> pino wrote in servertest.cpp:422
> > Why use normalStage as reference ?
> 
> Because every time there is a new line of data read from the socket, the stage is increased (see few lines above this).  Since:
> 
> - we want to stay at stage 1 until the reply of CAPABILITIES is over
> - it happens that the reply is read in multiple batches, and not just at once
> 
> then we need to reset the stage to be still 1 -- see the comment at the end of handleNntpConversation.

So we can use a reference not necessary a pointer where we need to check with Q_ASSERT if it's empty or not
and we don't need to use *stage == ... no ?

REPOSITORY
  R84 PIM: KMail Transport

REVISION DETAIL
  https://phabricator.kde.org/D6977

To: pino, #kde_pim, mlaurent
Cc: dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170731/53fa6fd6/attachment.html>