D6977: servertest: add NNTP support

Pino Toscano noreply at phabricator.kde.org
Sun Jul 30 09:32:08 BST 2017


pino added inline comments.

INLINE COMMENTS

> mlaurent wrote in servertest.cpp:422
> Why use normalStage as reference ?
> We don't use it as reference in other place as it's already defined
> 
> > it avoids to add an extra test
> ================================

> Why use normalStage as reference ?

Because every time there is a new line of data read from the socket, the stage is increased (see few lines above this).  Since:

- we want to stay at stage 1 until the reply of CAPABILITIES is over
- it happens that the reply is read in multiple batches, and not just at once

then we need to reset the stage to be still 1 -- see the comment at the end of handleNntpConversation.

REPOSITORY
  R84 PIM: KMail Transport

REVISION DETAIL
  https://phabricator.kde.org/D6977

To: pino, #kde_pim, mlaurent
Cc: dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170730/ea3d5344/attachment.html>


More information about the kde-pim mailing list