D6977: servertest: add NNTP support

Pino Toscano noreply at phabricator.kde.org
Mon Jul 31 06:33:21 BST 2017


pino added inline comments.

INLINE COMMENTS

> mlaurent wrote in servertest.cpp:422
> So we can use a reference not necessary a pointer where we need to check with Q_ASSERT if it's empty or not
> and we don't need to use *stage == ... no ?

The pointer instead of the reference makes it more clear it **is** subject to change, which is not when using a reference.  This is also the case for the `shouldStartTLS` parameter, in both the `handlePopConversation` function (already existing), and the `handleNntpConversation` which I added.

REPOSITORY
  R84 PIM: KMail Transport

REVISION DETAIL
  https://phabricator.kde.org/D6977

To: pino, #kde_pim, mlaurent
Cc: dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170731/e57585db/attachment.html>


More information about the kde-pim mailing list