Review Request 128605: [kmail] Fix jump lists by renaming org.kde.{kmail => kmail2}.desktop

[Andreas Sturmlechner]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128605/
-----------------------------------------------------------

(Updated Feb. 26, 2017, 2:18 p.m.)


Status
------

This change has been discarded.


Review request for KDEPIM and Laurent Montel.


Repository: kdepim


Description
-------

Currently broken because WM_CLASS is set to 'kmail2' which does not correspond with desktop file.

some IRC log:

Sho_: let me give you some context
Sho_: Plasma's Task Manager contains a complicated heuristic that tries to find out what app a window belongs to, working off of window and process metadata
Sho_: it's necessary to e.g. pin an app as a launcher based on a window, or to group windows belonging to the same app, or fetch jump list actions from the .desktop file
Sho_: because kmail sets bad metadata, the heuristic works only as far as being able to find the executable - that's enough to store a launcher, which then points at the executable and uses a base64 serialization of the window icon as icon for it
Sho_: but since it can't find the .desktop file, it can't e.g. show jump lists (or grab the right icon from the icon theme based on icon name)


Diffs
-----

  kmail/src/CMakeLists.txt 3df422d731393263f00ff26c35e62e47ec851d6f 
  kmail/src/data/org.kde.kmail.appdata.xml  
  kmail/src/data/org.kde.kmail.desktop  

Diff: https://git.reviewboard.kde.org/r/128605/diff/


Testing
-------

builds and runs, now also has jump lists (if kmail is started standalone)


Thanks,

Andreas Sturmlechner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170226/507768dd/attachment.html>