Review Request 128605: [kmail] Fix jump lists by renaming org.kde.{kmail => kmail2}.desktop

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128605/#review102555
-----------------------------------------------------------



Can we push this to master then? I just came up with the same patch in https://phabricator.kde.org/D4668

- David Faure


On Aug. 4, 2016, 9:29 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128605/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2016, 9:29 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Currently broken because WM_CLASS is set to 'kmail2' which does not correspond with desktop file.
> 
> some IRC log:
> 
> Sho_: let me give you some context
> Sho_: Plasma's Task Manager contains a complicated heuristic that tries to find out what app a window belongs to, working off of window and process metadata
> Sho_: it's necessary to e.g. pin an app as a launcher based on a window, or to group windows belonging to the same app, or fetch jump list actions from the .desktop file
> Sho_: because kmail sets bad metadata, the heuristic works only as far as being able to find the executable - that's enough to store a launcher, which then points at the executable and uses a base64 serialization of the window icon as icon for it
> Sho_: but since it can't find the .desktop file, it can't e.g. show jump lists (or grab the right icon from the icon theme based on icon name)
> 
> 
> Diffs
> -----
> 
>   kmail/src/CMakeLists.txt 3df422d731393263f00ff26c35e62e47ec851d6f 
>   kmail/src/data/org.kde.kmail.appdata.xml  
>   kmail/src/data/org.kde.kmail.desktop  
> 
> Diff: https://git.reviewboard.kde.org/r/128605/diff/
> 
> 
> Testing
> -------
> 
> builds and runs, now also has jump lists (if kmail is started standalone)
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170219/fade5063/attachment.html>