Review Request 130091: Check for null pointer.
Jos van den Oever
jos at vandenoever.info
Tue Apr 18 08:36:52 BST 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130091/
-----------------------------------------------------------
Review request for KDEPIM.
Repository: grantleetheme
Description
-------
AbstractTemplateLoader::loadByName returns a Grantlee::Template. A Grantlee::Template is a QSharedPointer<TemplateImpl>. This pointer may be null, e.g. in Grantlee::FileSystemTemplateLoader.
This patch adds a check to avoid a crash when a template could not be loaded.
Diffs
-----
src/grantleetheme.cpp b86fc3a
Diff: https://git.reviewboard.kde.org/r/130091/diff/
Testing
-------
On my setup tests fail with or without this patch.
Thanks,
Jos van den Oever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170418/4783e556/attachment.html>
More information about the kde-pim
mailing list