Review Request 130091: Check for null pointer.

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130091/#review103057
-----------------------------------------------------------




src/grantleetheme.cpp (line 107)
<https://git.reviewboard.kde.org/r/130091/#comment68556>

    Perhaps i18n no ?
    it will be displaying in viewer directly.


- Laurent Montel


On April 18, 2017, 7:36 a.m., Jos van den Oever wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130091/
> -----------------------------------------------------------
> 
> (Updated April 18, 2017, 7:36 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: grantleetheme
> 
> 
> Description
> -------
> 
> AbstractTemplateLoader::loadByName returns a Grantlee::Template. A Grantlee::Template is a QSharedPointer<TemplateImpl>. This pointer may be null, e.g. in Grantlee::FileSystemTemplateLoader.
> 
> This patch adds a check to avoid a crash when a template could not be loaded.
> 
> 
> Diffs
> -----
> 
>   src/grantleetheme.cpp b86fc3a 
> 
> Diff: https://git.reviewboard.kde.org/r/130091/diff/
> 
> 
> Testing
> -------
> 
> On my setup tests fail with or without this patch.
> 
> 
> Thanks,
> 
> Jos van den Oever
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170418/25a7df9b/attachment.html>