Review Request 130091: Check for null pointer.

Tue Apr 18 10:44:31 BST 2017

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130091/
-----------------------------------------------------------

(Updated apr 18, 2017, 9:44 a.m.)

Review request for KDEPIM.

Repository: grantleetheme

Description
-------

AbstractTemplateLoader::loadByName returns a Grantlee::Template. A Grantlee::Template is a QSharedPointer<TemplateImpl>. This pointer may be null, e.g. in Grantlee::FileSystemTemplateLoader.

This patch adds a check to avoid a crash when a template could not be loaded.

Diffs (updated)
-----

  src/grantleetheme.cpp b86fc3a 

Diff: https://git.reviewboard.kde.org/r/130091/diff/

Testing
-------

On my setup tests fail with or without this patch.

File Attachments (updated)
----------------

g.patch
  https://git.reviewboard.kde.org/media/uploaded/files/2017/04/18/608fbab4-5ba1-47d3-b3b2-3330f2a187db__g.patch

Thanks,

Jos van den Oever

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170418/af3d7f3c/attachment.html>