Review Request 130091: Check for null pointer.

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130091/#review103061
-----------------------------------------------------------


Ship it!




Commit in 17.04 + git merge in master.
Thanks
Regards

- Laurent Montel


On April 18, 2017, 9:44 a.m., Jos van den Oever wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130091/
> -----------------------------------------------------------
> 
> (Updated April 18, 2017, 9:44 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: grantleetheme
> 
> 
> Description
> -------
> 
> AbstractTemplateLoader::loadByName returns a Grantlee::Template. A Grantlee::Template is a QSharedPointer<TemplateImpl>. This pointer may be null, e.g. in Grantlee::FileSystemTemplateLoader.
> 
> This patch adds a check to avoid a crash when a template could not be loaded.
> 
> 
> Diffs
> -----
> 
>   src/grantleetheme.cpp b86fc3a 
> 
> Diff: https://git.reviewboard.kde.org/r/130091/diff/
> 
> 
> Testing
> -------
> 
> On my setup tests fail with or without this patch.
> 
> 
> File Attachments
> ----------------
> 
> g.patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2017/04/18/608fbab4-5ba1-47d3-b3b2-3330f2a187db__g.patch
> 
> 
> Thanks,
> 
> Jos van den Oever
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170418/904495f9/attachment.html>