[Differential] [Commented On] D1639: Implement opportunistic encryption

[dvratil (Daniel Vrátil)]

dvratil added a comment.


  In https://phabricator.kde.org/D1639#53746, @aheinecke wrote:
  
  > I think we should untoggle encryption though if a recipient is selected for whom encryption is "Kleo::Impossible"
  
  
  You mean not encrypt the email at all if all the recipients are `Kleo::Impossible`, or even if only one is `Kleo::Impossible`?
  
  > I have keys for all the recipients. In my keyring. But the last andre.heinecke at intevation.de only got the icon for 1-2 seconds then it dissapeared again. This happens more often when I select the recipient from the completion window and not by adding it with "typing + enter". There probably is a problem that two Jobs are started and somehow mixed up and one of the jobs yields no result. Can you reproduce this or should I add some debug code to investigate?
  
  I can't reproduce, probably because for me the key lookup finishes immediately due to my keychain being small. I can however see the problem (probably). If the lookup takes a couple of seconds and the lookup for "name at example.com" finishes before the already-running lookup for "name at example.co", then once the lookup for "name at example.co" finishes, it will overwrite the result set by the second lookup.
  
  I guess the lookups take a couple of seconds in a large keychain and some may be slightly faster - I would assume that looking for a known email yields a result faster due to finding a match in some hash table while looking for unknown email hits a slow path as it has to go through each key in the keychain.

REPOSITORY
  R206 KMail

REVISION DETAIL
  https://phabricator.kde.org/D1639

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil, mlaurent, aheinecke
Cc: knauss, kde-pim, spencerb, dvasin, winterz, vkrause, mlaurent, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20160930/963f4862/attachment.html>