[Differential] [Commented On] D1639: Implement opportunistic encryption

[aheinecke (Andre Heinecke)]

aheinecke added a comment.


  Hi Dan,
  
  Looks good to me. And the option in identity is good.
  
  The Icons need some love though but thats a bit unrelated of the functionality :-)
  
  I think we should untoggle encryption though if a recipient is selected for whom encryption is "Kleo::Impossible"
  
  When testing this I noticed some strange behavior. Icons appear and then shortly after disappear again.
  
  F345723: kmail-encrypt.png <https://phabricator.kde.org/F345723>
  
  I have keys for all the recipients. In my keyring. But the last andre.heinecke at intevation.de only got the icon for 1-2 seconds then it dissapeared again. This happens more often when I select the recipient from the completion window and not by adding it with "typing + enter". There probably is a problem that two Jobs are started and somehow mixed up and one of the jobs yields no result. Can you reproduce this or should I add some debug code to investigate?

REPOSITORY
  R206 KMail

REVISION DETAIL
  https://phabricator.kde.org/D1639

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil, mlaurent, aheinecke
Cc: knauss, kde-pim, spencerb, dvasin, winterz, vkrause, mlaurent, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20160930/cfb838bb/attachment.html>