[Differential] [Commented On] D3203: icalformat: remove QByteArray->QString->QByteArray roundtrip.

[knauss (Sandro Knauß)]

knauss added a comment.


  This roundtrip may makes a difference if you have non UTF-8 encoded files- did you check against those? I know that I added those roundtrips at other places, because otherwise the string weren't formatted correctly.
  
  Removing the trimmed function means, that for files with only spaces, you do not return true, but will push this to fromRawString function. Is this function aware of those files? Do we will get the same result aka true?
  
  It would be nice if you add tests for this, to make sure nothing is changed.

REPOSITORY
  rKCALENDARCORE KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D3203

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dfaure, djarvie, smartins
Cc: knauss, kde-pim, #kde_pim, spencerb, dvasin, winterz, vkrause, mlaurent, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20161030/ca820074/attachment.html>