[Differential] [Commented On] D3203: icalformat: remove QByteArray->QString->QByteArray roundtrip.

[knauss (Sandro Knauß)]

knauss added a comment.


  I have fixed issues with strange locales/encodings for kolab-client and there I learn, if you make sense to fail as early as possible :)
  
  > I do not believe in making everything slower just to change the error handling for an invalid case (and not necessarily for the better).
  
  Well is it really that much slower?A file should be reread once in some hours/minutes.
  I am not happy with the error handling he have at the moment (none). But I see the potential of you patch to add nonvalid data to akonadi and than somewhere in korganzier this can crash and than tell the user, oh that was the wrong file encoding?

REPOSITORY
  rKCALENDARCORE KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D3203

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dfaure, djarvie, smartins
Cc: knauss, kde-pim, #kde_pim, spencerb, dvasin, winterz, vkrause, mlaurent, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20161031/a75ba8e0/attachment.html>