[Differential] [Commented On] D3203: icalformat: remove QByteArray->QString->QByteArray roundtrip.

dfaure (David Faure) noreply at phabricator.kde.org
Sun Oct 30 22:41:50 GMT 2016


dfaure added a comment.


  You'll have to explain to me how a textstream with ts.setCodec("UTF-8"); could possibly handle non-utf8 input.
  
  AFAIK it cannot, therefore the objection is moot.
  
  OK for keeping the trimmed(), I hadn't noticed the isEmpty() check below.

REPOSITORY
  rKCALENDARCORE KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D3203

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dfaure, djarvie, smartins
Cc: knauss, kde-pim, #kde_pim, spencerb, dvasin, winterz, vkrause, mlaurent, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20161030/6dc66e93/attachment.html>


More information about the kde-pim mailing list