[Kde-pim] [Differential] [Request, 1 line] D1964: Fix opening attachments in Opaque S/MIME encrypted messages

dvratil (Daniel Vrátil) noreply at phabricator.kde.org
Mon Jun 20 19:05:20 BST 2016


dvratil created this revision.
dvratil added a reviewer: knauss.
dvratil set the repository for this revision to rMESSAGELIB PIM: Message Library.
dvratil added a project: KDE PIM.
Restricted Application added a subscriber: kde-pim.

REVISION SUMMARY
  This fixes opening attachments in Opaque S/MIME encrypted messages. The problem is that the verified signed part was not attached to the encrypted part, so that the URL for the attachment was invalid (attachment:0::2?part=body) - because lookup in extraContents() would fail for the intermediate part. By making sure that the signed part is attached to the crypto part, the extraContents lookup is successful for the entire chain and everything works.

TEST PLAN
  Sent myself an Opaque S/MIME encrypted message with attachment and tried opening the attachment.
  Tests pass

REPOSITORY
  rMESSAGELIB PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D1964

AFFECTED FILES
  mimetreeparser/src/viewer/messagepart.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil, knauss
Cc: kde-pim, dvasin, winterz, smartins, vkrause, mlaurent, knauss, dvratil
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list