Review Request 128649: Add options for JSON serialization of File metadata

Daniel Vrátil dvratil at kde.org
Wed Aug 10 15:36:51 BST 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128649/#review98293
-----------------------------------------------------------


Ship it!




Ship It!

- Daniel Vrátil


On Aug. 10, 2016, 4:26 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128649/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2016, 4:26 p.m.)
> 
> 
> Review request for KDEPIM and Daniel Vrátil.
> 
> 
> Repository: libkgapi
> 
> 
> Description
> -------
> 
> This patch adds support for options when serializing `File` metadata to JSON.
> We need to drop the `createdDate` entry at least when moving/renaming URLs (see https://phabricator.kde.org/T3423)
> 
> Does the new enum need a `@since` tag?
> 
> 
> Diffs
> -----
> 
>   src/drive/file.h 8605bd9 
>   src/drive/file.cpp 0696009 
>   src/drive/fileabstractuploadjob.h e92f048 
>   src/drive/fileabstractuploadjob.cpp 49cad20 
>   src/drive/filemodifyjob.cpp 0b2b6c3 
> 
> Diff: https://git.reviewboard.kde.org/r/128649/diff/
> 
> 
> Testing
> -------
> 
> Moving and renaming URLs now works as expected in kio-gdrive.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20160810/8c09d4ea/attachment.html>


More information about the kde-pim mailing list