Review Request 128649: Add options for JSON serialization of File metadata

Elvis Angelaccio elvis.angelaccio at kdemail.net
Wed Aug 10 16:06:28 BST 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128649/
-----------------------------------------------------------

(Updated Aug. 10, 2016, 3:06 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM and Daniel Vrátil.


Changes
-------

Submitted with commit 514a12e60de4d2902dcef420fcaa59d19cf43337 by Elvis Angelaccio to branch LibKGAPI/5.3.


Repository: libkgapi


Description
-------

This patch adds support for options when serializing `File` metadata to JSON.
We need to drop the `createdDate` entry at least when moving/renaming URLs (see https://phabricator.kde.org/T3423)

Does the new enum need a `@since` tag?


Diffs
-----

  src/drive/file.h 8605bd9 
  src/drive/file.cpp 0696009 
  src/drive/fileabstractuploadjob.h e92f048 
  src/drive/fileabstractuploadjob.cpp 49cad20 
  src/drive/filemodifyjob.cpp 0b2b6c3 

Diff: https://git.reviewboard.kde.org/r/128649/diff/


Testing
-------

Moving and renaming URLs now works as expected in kio-gdrive.


Thanks,

Elvis Angelaccio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20160810/05562745/attachment.html>


More information about the kde-pim mailing list