Review Request 128649: Add options for JSON serialization of File metadata

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128649/#review98292
-----------------------------------------------------------



You could add `@since 5.3.1` to the enum I guess...

Otherwise looks good, just minor nitpicks.


src/drive/file.h (line 301)
<https://git.reviewboard.kde.org/r/128649/#comment66209>

    Call this `SerializationOption`, declare `SerializationOptions` via `Q_DECLARE_FLAGS` (see below)



src/drive/file.h (line 302)
<https://git.reviewboard.kde.org/r/128649/#comment66212>

    Use `NoOptions` instead please, `Default` sounds to me like if it would turn on some options, but leave some other off. `NoOptions` is more obvious IMO.



src/drive/file.h (line 305)
<https://git.reviewboard.kde.org/r/128649/#comment66210>

    And use `Q_DECLARE_FLAGS(SerializationOptions, SerializationOption)` here



src/drive/file.h (line 600)
<https://git.reviewboard.kde.org/r/128649/#comment66211>

    And add `Q_DECLARE_OPERATORS_FOR_FLAGS(KGAPI2::Drive::File::SerializationOptions)` here


- Daniel Vrátil


On Aug. 10, 2016, 3:48 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128649/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2016, 3:48 p.m.)
> 
> 
> Review request for KDEPIM and Daniel Vrátil.
> 
> 
> Repository: libkgapi
> 
> 
> Description
> -------
> 
> This patch adds support for options when serializing `File` metadata to JSON.
> We need to drop the `createdDate` entry at least when moving/renaming URLs (see https://phabricator.kde.org/T3423)
> 
> Does the new enum need a `@since` tag?
> 
> 
> Diffs
> -----
> 
>   src/drive/file.h 8605bd9 
>   src/drive/file.cpp 0696009 
>   src/drive/fileabstractuploadjob.h e92f048 
>   src/drive/fileabstractuploadjob.cpp 49cad20 
>   src/drive/filemodifyjob.cpp 0b2b6c3 
> 
> Diff: https://git.reviewboard.kde.org/r/128649/diff/
> 
> 
> Testing
> -------
> 
> Moving and renaming URLs now works as expected in kio-gdrive.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20160810/56068058/attachment.html>