[Kde-pim] Review Request 125364: Fix heap-use-after-free in ICalFormatImpl::readICalDateTime

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125364/#review85842
-----------------------------------------------------------

Ship it!


Looks good to me.

- Volker Krause


On Sept. 23, 2015, 4:57 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125364/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2015, 4:57 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Laurent Montel.
> 
> 
> Repository: kcalcore
> 
> 
> Description
> -------
> 
> tzid = parts.first().toAscii(); was assigning the temporary const char * to tzid that was invalid on the next line, so instead of keeping a const char * keep a QByteArray
> 
> https://build.kde.org/job/kcalcore%20Applications-15.08%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/lastCompletedBuild/testReport/%28root%29/TestSuite/testreadrecurrenceid/
> 
> 
> Diffs
> -----
> 
>   src/icalformat_p.cpp 6db5714 
> 
> Diff: https://git.reviewboard.kde.org/r/125364/diff/
> 
> 
> Testing
> -------
> 
> valgrind doesn't complain anymore
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/