[Kde-pim] Review Request 125368: Fix heap-use-after-free in the imap resource

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125368/#review85850
-----------------------------------------------------------

Ship it!


Seems ok for me.
Ship it

- Laurent Montel


On sep. 24, 2015, 12:43 matin, Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125368/
> -----------------------------------------------------------
> 
> (Updated sep. 24, 2015, 12:43 matin)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> Keep the collection() around more time, otherwise we're accessing already deleted data.
> 
> See
> https://build.kde.org/user/aacid/my-views/view/KDE%20Applications%2015.08/job/kdepim-runtime%20Applications-15.08%20stable-kf5-qt5/21/PLATFORM=Linux,compiler=gcc/testReport/junit/%28root%29/TestSuite/testmoveitemstask/
> https://build.kde.org/user/aacid/my-views/view/KDE%20Applications%2015.08/job/kdepim-runtime%20Applications-15.08%20stable-kf5-qt5/21/PLATFORM=Linux,compiler=gcc/testReport/junit/%28root%29/TestSuite/testchangecollectiontask/
> https://build.kde.org/user/aacid/my-views/view/KDE%20Applications%2015.08/job/kdepim-runtime%20Applications-15.08%20stable-kf5-qt5/21/PLATFORM=Linux,compiler=gcc/testReport/junit/%28root%29/TestSuite/testadditemtask/
> 
> 
> Diffs
> -----
> 
>   resources/imap/additemtask.cpp e2bd6fd 
>   resources/imap/changecollectiontask.cpp 3e31106 
>   resources/imap/moveitemstask.cpp a6329db 
> 
> Diff: https://git.reviewboard.kde.org/r/125368/diff/
> 
> 
> Testing
> -------
> 
> Valgrind is happy, tests pass.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/