[Kde-pim] Review Request 125364: Fix heap-use-after-free in ICalFormatImpl::readICalDateTime

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125364/
-----------------------------------------------------------

(Updated Sept. 23, 2015, 7:36 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM-Libraries and Laurent Montel.


Changes
-------

Submitted with commit 702b55ac4a855fe2a5f7a06915ff2ae8a77a2b04 by Albert Astals Cid to branch Applications/15.08.


Repository: kcalcore


Description
-------

tzid = parts.first().toAscii(); was assigning the temporary const char * to tzid that was invalid on the next line, so instead of keeping a const char * keep a QByteArray

https://build.kde.org/job/kcalcore%20Applications-15.08%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/lastCompletedBuild/testReport/%28root%29/TestSuite/testreadrecurrenceid/


Diffs
-----

  src/icalformat_p.cpp 6db5714 

Diff: https://git.reviewboard.kde.org/r/125364/diff/


Testing
-------

valgrind doesn't complain anymore


Thanks,

Albert Astals Cid

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/