[Kde-pim] Review Request 122223: add Akonadi::MessageFlags::copyMessageFlags() which is needed in a lot places all over kdepim code

[laurent Montel]

Le Sunday 25 January 2015 16:00:04 Martin Koller a écrit :
> On Friday 23 January 2015 16:06:38 Laurent Montel wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://git.reviewboard.kde.org/r/122223/#review74606
> > -----------------------------------------------------------
> > 
> > akonadi/kmime/messageflags.h
> > <https://git.reviewboard.kde.org/r/122223/#comment51716>
> > 
> >     could you create an unitest for it please ?
> 
> while trying to create a useful unittest, I found a possible problem with
> the method:

Unitest is very useful :) We found new bug :)

> 
> The code in it was just copied from some existing resource implementations.
> 
> However, I think what it does is not entirely correct:
> 
>     if (KMime::isInvitation(&message))
>         item.setFlag(Akonadi::MessageFlags::HasInvitation);
> 
> This tests just if the message itself is an invitation.
> korganizer however sends new invitations as multipart messages.
> And the flag name is "HasInvitation" - should that not traverse the whole
> message tree ?

For me it seems logical indeed.
But I am not expert about “invitation” code but seems logic for me.

> 
> I think the attached patch would be more correct.
> What do you think ?

-- 
Laurent Montel | laurent.montel at kdab.com | KDE/Qt Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53,  http://www.kdab.fr


_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/