[Kde-pim] Review Request 122223: add Akonadi::MessageFlags::copyMessageFlags() which is needed in a lot places all over kdepim code

[Martin Koller]

On Friday 23 January 2015 16:06:38 Laurent Montel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122223/#review74606
> -----------------------------------------------------------

> akonadi/kmime/messageflags.h
> <https://git.reviewboard.kde.org/r/122223/#comment51716>
> 
>     could you create an unitest for it please ?

while trying to create a useful unittest, I found a possible problem with
the method:

The code in it was just copied from some existing resource implementations.

However, I think what it does is not entirely correct:

    if (KMime::isInvitation(&message))
        item.setFlag(Akonadi::MessageFlags::HasInvitation);

This tests just if the message itself is an invitation.
korganizer however sends new invitations as multipart messages.
And the flag name is "HasInvitation" - should that not traverse the whole message tree ?

I think the attached patch would be more correct.
What do you think ?

-- 
Best regards/Schöne Grüße

Martin
A: Because it breaks the logical sequence of discussion
Q: Why is top posting bad?

()  ascii ribbon campaign - against html e-mail 
/\                        - against proprietary attachments

Geschenkideen, Accessoires, Seifen, Kulinarisches: www.lillehus.at
-------------- next part --------------
A non-text attachment was scrubbed...
Name: invitation.diff
Type: text/x-patch
Size: 3428 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20150125/6c73a2eb/attachment.bin>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/