[Kde-pim] Review Request 122223: add Akonadi::MessageFlags::copyMessageFlags() which is needed in a lot places all over kdepim code
Martin Koller
kollix at aon.at
Sat Jan 31 11:44:27 GMT 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122223/
-----------------------------------------------------------
(Updated Jan. 31, 2015, 11:44 a.m.)
Review request for KDEPIM-Libraries and Laurent Montel.
Changes
-------
added unit-test.
added new method hasInvitation() which recursively checks the MIME tree if a node is an invitation.
This works in the same way as hasAttachment() works.
(this is needed since invitation related mails can be multipart/mixed)
Repository: kdepimlibs
Description
-------
During my investigation of several problems with kmail correctly displaying email flags, I encountered a lot of places where there were code duplication doing all the same steps to copy mail flags from a KMime::Message into an Akonadi::Item.
To get rid of this code duplication, I created a new method.
I'll create review requests for the other repos as well (kdepim-runtime, kdepim)
Diffs (updated)
-----
kmime/tests/auto/CMakeLists.txt 7469914
kmime/tests/auto/messagetest.h 1fb0a69
kmime/tests/auto/messagetest.cpp 91d5f72
mailtransport/messagequeuejob.cpp 9265440
kmime/kmime_util.cpp d68588c
akonadi/kmime/messageflags.h 39e2df3
akonadi/kmime/messageflags.cpp 86c79df
kmime/kmime_util.h 9fb071a
Diff: https://git.reviewboard.kde.org/r/122223/diff/
Testing
-------
with kmail
Thanks,
Martin Koller
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list