[Kde-pim] Review Request 124952: libkleo: Port cryptoconfigdialog to QDialog

[Andre Heinecke]

> On Aug. 27, 2015, 5:06 p.m., Laurent Montel wrote:
> > libkleo/ui/cryptoconfigmodule.cpp, line 920
> > <https://git.reviewboard.kde.org/r/124952/diff/2/?file=399348#file399348line920>
> >
> >     Are you sure that it's necessary to be static ?
> >     Otherwise it seems ok this patch.

Hum,.. No not really, I just went with my usual mantra "If it's a local helper method declare it statically" because in C that's how you do this to avoid name clashes. I can't find any good information if this should be done in c++ or not. So I take your comment to remove it and then ship it. A pointer in IRC or so why I should or should not declare a C++ function (without a class) to be static or not would be appreciated. I'm running on C here.


- Andre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124952/#review84483
-----------------------------------------------------------


On Aug. 27, 2015, 2:28 p.m., Andre Heinecke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124952/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 2:28 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> This is the last remaining usage of KDialog in libkleo
> 
> Minor functionality change is that a read only Keyserver widget now behaves the same as the ldap dialog with regards to shown buttons.
> 
> 
> Diffs
> -----
> 
>   libkleo/ui/cryptoconfigmodule.cpp be4f84d 
> 
> Diff: https://git.reviewboard.kde.org/r/124952/diff/
> 
> 
> Testing
> -------
> 
> Compiles, tried out both.
> 
> 
> Thanks,
> 
> Andre Heinecke
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/