[Kde-pim] Review Request 124955: libkleo: Remove KUrlRequester from cryptoconfigmodule

[Andre Heinecke]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124955/
-----------------------------------------------------------

(Updated Aug. 28, 2015, 8:33 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM.


Changes
-------

Submitted with commit edb6924a102816f5c91d7ee3a5e57aa9e2a914df by Andre Heinecke to branch master.


Repository: kdepim


Description
-------

This patch is a very minor functionaly loss but removes libkleo's dependency to KIO.
You will not get autocompletion anymore when configuring log files for gnupg compents when you are not using the filedialog.

I find this completely acceptable. Configuring log files is an expert feature and the autocompletion comes at a dependency to KIO which I'd rather avoid. And which we always avoided on windows anyway.

This really just influences the log file settings. I could not find any other Path setting with gpgconf.

CryptoConfigEntryDirPath -> This class is only used by the chiasmusbackend.
CryptoConfigEntryURL -> I did not find any usage of this class. I think it can be removed but this would be another patch.

(See libkleo/backends/qgpgme/qgpgmecryptoconfig.cpp line 459ff "knownArgType")


Diffs
-----

  libkleo/ui/cryptoconfigmodule.cpp 42a52e4 
  libkleo/ui/cryptoconfigmodule_p.h 253c3c7 

Diff: https://git.reviewboard.kde.org/r/124955/diff/


Testing
-------

Kleopatra in Gpg4win uses this codepath since: ever


Thanks,

Andre Heinecke

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/