[Kde-pim] Review Request 124952: libkleo: Port cryptoconfigdialog to QDialog

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124952/#review84483
-----------------------------------------------------------



libkleo/ui/cryptoconfigmodule.cpp (line 917)
<https://git.reviewboard.kde.org/r/124952/#comment58481>

    Are you sure that it's necessary to be static ?
    Otherwise it seems ok this patch.


- Laurent Montel


On août 27, 2015, 2:28 après-midi, Andre Heinecke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124952/
> -----------------------------------------------------------
> 
> (Updated août 27, 2015, 2:28 après-midi)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> This is the last remaining usage of KDialog in libkleo
> 
> Minor functionality change is that a read only Keyserver widget now behaves the same as the ldap dialog with regards to shown buttons.
> 
> 
> Diffs
> -----
> 
>   libkleo/ui/cryptoconfigmodule.cpp be4f84d 
> 
> Diff: https://git.reviewboard.kde.org/r/124952/diff/
> 
> 
> Testing
> -------
> 
> Compiles, tried out both.
> 
> 
> Thanks,
> 
> Andre Heinecke
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/