[Kde-pim] Review Request 124955: libkleo: Remove KUrlRequester from cryptoconfigmodule

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124955/#review84502
-----------------------------------------------------------

Ship it!


Ok if you think it's better.
I am not against.

- Laurent Montel


On août 27, 2015, 6:52 après-midi, Andre Heinecke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124955/
> -----------------------------------------------------------
> 
> (Updated août 27, 2015, 6:52 après-midi)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> This patch is a very minor functionaly loss but removes libkleo's dependency to KIO.
> You will not get autocompletion anymore when configuring log files for gnupg compents when you are not using the filedialog.
> 
> I find this completely acceptable. Configuring log files is an expert feature and the autocompletion comes at a dependency to KIO which I'd rather avoid. And which we always avoided on windows anyway.
> 
> This really just influences the log file settings. I could not find any other Path setting with gpgconf.
> 
> CryptoConfigEntryDirPath -> This class is only used by the chiasmusbackend.
> CryptoConfigEntryURL -> I did not find any usage of this class. I think it can be removed but this would be another patch.
> 
> (See libkleo/backends/qgpgme/qgpgmecryptoconfig.cpp line 459ff "knownArgType")
> 
> 
> Diffs
> -----
> 
>   libkleo/ui/cryptoconfigmodule.cpp 42a52e4 
>   libkleo/ui/cryptoconfigmodule_p.h 253c3c7 
> 
> Diff: https://git.reviewboard.kde.org/r/124955/diff/
> 
> 
> Testing
> -------
> 
> Kleopatra in Gpg4win uses this codepath since: ever
> 
> 
> Thanks,
> 
> Andre Heinecke
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/