[Kde-pim] Review Request 118663: Outline of the receiver model

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118663/#review60353
-----------------------------------------------------------



mobile/api/mail/folderlist.h
<https://git.reviewboard.kde.org/r/118663/#comment42065>

    just revert this change for now



mobile/api/mail/receivermodel.h
<https://git.reviewboard.kde.org/r/118663/#comment42066>

    just a minor nit pick: can you add a new line before this one?
    to visually separate the methods that are part of the base model API and the ones that are specific to this model



mobile/api/mail/receivermodel.cpp
<https://git.reviewboard.kde.org/r/118663/#comment42067>

    identation



mobile/api/mail/receivermodel.cpp
<https://git.reviewboard.kde.org/r/118663/#comment42072>

    hmm. this looks like it would result in an endless loop.
    the signal is emitted from removeRecipient.
    What do you needs this for?



mobile/api/mail/receivermodel.cpp
<https://git.reviewboard.kde.org/r/118663/#comment42068>

    block opening brace goes onto the same line as the if/else/else if/while/for/switch.
    http://techbase.kde.org/Policies/Kdepim_Coding_Style



mobile/api/mail/receivermodel.cpp
<https://git.reviewboard.kde.org/r/118663/#comment42069>

    since you always return true, what is the intent of the bool result?



mobile/api/mail/receivermodel.cpp
<https://git.reviewboard.kde.org/r/118663/#comment42071>

    intentation


- Kevin Krammer


On June 17, 2014, 4:09 p.m., Abhijeet Nikam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118663/
> -----------------------------------------------------------
> 
> (Updated June 17, 2014, 4:09 p.m.)
> 
> 
> Review request for KDEPIM, Kevin Krammer and Michael Bohlender.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> These is the basic outline of my receiver model, I wanted to have a review of this before further implementing the .cpp file.
> 
> 
> Diffs
> -----
> 
>   messagecomposer/recipient/recipient.h 0eea70b 
>   messagecomposer/recipient/recipient.cpp 3a63625 
>   mobile/api/mail/CMakeLists.txt 9fceb28 
>   mobile/api/mail/folderlist.h 06f92f2 
>   mobile/api/mail/mailplugin.cpp 51379e1 
>   mobile/api/mail/receivermodel.h PRE-CREATION 
>   mobile/api/mail/receivermodel.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118663/diff/
> 
> 
> Testing
> -------
> 
> Compiles without any errors.
> 
> 
> Thanks,
> 
> Abhijeet Nikam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/