[Kde-pim] Review Request 118663: Outline of the receiver model

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118663/#review60408
-----------------------------------------------------------


Close to perfect


mobile/api/mail/receivermodel.h
<https://git.reviewboard.kde.org/r/118663/#comment42141>

    just a nitpick: in Qt it is customary to mark QObject subclass constructors that can be called with just one argument with the keyword explicit.
    e.g.
    
    explicit ReceiverModel( .... )
    



mobile/api/mail/receivermodel.h
<https://git.reviewboard.kde.org/r/118663/#comment42149>

    I'd say we make this
    
    addRecipient( const MessageComposer::Recipient::Ptr &recipient )



mobile/api/mail/receivermodel.cpp
<https://git.reviewboard.kde.org/r/118663/#comment42142>

    intendation seems off by four spaces. should be aligned with QHash



mobile/api/mail/receivermodel.cpp
<https://git.reviewboard.kde.org/r/118663/#comment42143>

    you can remove that, parent is used by the if () above



mobile/api/mail/receivermodel.cpp
<https://git.reviewboard.kde.org/r/118663/#comment42144>

    intendation off by one :)



mobile/api/mail/receivermodel.cpp
<https://git.reviewboard.kde.org/r/118663/#comment42146>

    I am not sure we want to assert here, the user of the model has currently no way to check that.
    What do you guys think?



mobile/api/mail/receivermodel.cpp
<https://git.reviewboard.kde.org/r/118663/#comment42148>

    space after keyword


- Kevin Krammer


On June 18, 2014, 12:45 p.m., Abhijeet Nikam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118663/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 12:45 p.m.)
> 
> 
> Review request for KDEPIM, Kevin Krammer and Michael Bohlender.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> These is the basic outline of my receiver model, I wanted to have a review of this before further implementing the .cpp file.
> 
> 
> Diffs
> -----
> 
>   messagecomposer/recipient/recipient.h 0eea70b 
>   messagecomposer/recipient/recipient.cpp 3a63625 
>   mobile/api/mail/CMakeLists.txt 9fceb28 
>   mobile/api/mail/mailplugin.cpp 51379e1 
>   mobile/api/mail/receivermodel.h PRE-CREATION 
>   mobile/api/mail/receivermodel.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118663/diff/
> 
> 
> Testing
> -------
> 
> Compiles without any errors.
> 
> 
> Thanks,
> 
> Abhijeet Nikam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/