[Kde-pim] Review Request 118663: Outline of the receiver model

Abhijeet Nikam connect08nikam at gmail.com
Tue Jun 17 17:09:22 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118663/
-----------------------------------------------------------

(Updated June 17, 2014, 4:09 p.m.)


Review request for KDEPIM, Kevin Krammer and Michael Bohlender.


Changes
-------

I have made the corrections. I have used a signal while removing recipients. Will that be enough for the check? I am going wrong some where in creating the patch, hence the uncessary patches are getting added too.


Repository: kdepim


Description
-------

These is the basic outline of my receiver model, I wanted to have a review of this before further implementing the .cpp file.


Diffs (updated)
-----

  messagecomposer/recipient/recipient.h 0eea70b 
  messagecomposer/recipient/recipient.cpp 3a63625 
  mobile/api/mail/CMakeLists.txt 9fceb28 
  mobile/api/mail/folderlist.h 06f92f2 
  mobile/api/mail/mailplugin.cpp 51379e1 
  mobile/api/mail/receivermodel.h PRE-CREATION 
  mobile/api/mail/receivermodel.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/118663/diff/


Testing
-------

Compiles without any errors.


Thanks,

Abhijeet Nikam

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list