[Kde-pim] Review Request 118608: Review for API - mail composer class

[Michael Bohlender]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118608/#review59538
-----------------------------------------------------------



mobile/api/mail/messagecompose.h
<https://git.reviewboard.kde.org/r/118608/#comment41495>

    I think "Composer" would be a better name then "MessageCompose"



mobile/api/mail/messagecompose.h
<https://git.reviewboard.kde.org/r/118608/#comment41490>

    Please remember our API discussion. We agreed on having a StringList of emails for  the first iteration (and later a model). You can then add and remove by addCC(email) / removeCC(email). same goes for every other property where we can have multiple entries.



mobile/api/mail/messagecompose.h
<https://git.reviewboard.kde.org/r/118608/#comment41491>

    I assume that you want to commit a patch that you add to review board "as is". Please do not put commented code, that was never used in your future review requests.



mobile/api/mail/messagecompose.cpp
<https://git.reviewboard.kde.org/r/118608/#comment41493>

    minor coding style issue.  & belongs to the from (" QString &from). same for the rest of the file.


- Michael Bohlender


On June 7, 2014, 9:19 p.m., Abhijeet Nikam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118608/
> -----------------------------------------------------------
> 
> (Updated June 7, 2014, 9:19 p.m.)
> 
> 
> Review request for KDEPIM and Kevin Krammer.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Api for Creating the text Mail. I have also added the function for sending the mail. Sending the mail part is yet to be tested.
> 
> 
> Diffs
> -----
> 
>   mobile/api/mail/messagecompose.h PRE-CREATION 
>   mobile/api/mail/messagecompose.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118608/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhijeet Nikam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/