[Kde-pim] Review Request 118608: Review for API - mail composer class

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118608/#review59548
-----------------------------------------------------------



mobile/api/mail/messagecompose.h
<https://git.reviewboard.kde.org/r/118608/#comment41501>

    since this is going to be API I would say we better use the LGPL



mobile/api/mail/messagecompose.h
<https://git.reviewboard.kde.org/r/118608/#comment41502>

    In general we try to follow a certain ordering of includes:
    - first project local
    - then local (module) libraries
    - then KDEPIM libraries
    - then KDE libraries
    - then Qt libraries
    - then system libraries
    
    Not strictly necessary but oreferred



mobile/api/mail/messagecompose.h
<https://git.reviewboard.kde.org/r/118608/#comment41503>

    I'd say try to avoid "using namespace" in headers.
    It a header becomes a public header at some point this would affect other code, so better keep it to sources files at all times.
    And as far as I can see it is not necessary here at all, the usages of this namespace later on are always fully qualified



mobile/api/mail/messagecompose.h
<https://git.reviewboard.kde.org/r/118608/#comment41504>

    Indeed.
    Just as an explanation: the NOTIFY section specifies the signal that QML will use to detect changes in the property.
    
    A property which is supposed to be used from QML should either have NOTIFY followed by a signal or CONSTANT (but then obviously without a WRITE section)



mobile/api/mail/messagecompose.cpp
<https://git.reviewboard.kde.org/r/118608/#comment41506>

    A property setter for a propery exported to QML needs to emit a change signal if the property value changes (and ideally only when it actually changes)


- Kevin Krammer


On June 7, 2014, 9:19 p.m., Abhijeet Nikam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118608/
> -----------------------------------------------------------
> 
> (Updated June 7, 2014, 9:19 p.m.)
> 
> 
> Review request for KDEPIM and Kevin Krammer.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Api for Creating the text Mail. I have also added the function for sending the mail. Sending the mail part is yet to be tested.
> 
> 
> Diffs
> -----
> 
>   mobile/api/mail/messagecompose.h PRE-CREATION 
>   mobile/api/mail/messagecompose.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118608/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhijeet Nikam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/