[Kde-pim] Review Request 118608: Review for API - mail composer class
Jan Kundrát
jkt at flaska.net
Sat Jun 7 22:32:03 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118608/#review59529
-----------------------------------------------------------
There's also a related ML thread about exactly the same API design in Trojita, so you might be interested to check it out -- see http://thread.gmane.org/gmane.mail.trojita.general/1066 .
mobile/api/mail/messagecompose.h
<https://git.reviewboard.kde.org/r/118608/#comment41483>
There's no NOTIFY for these properties.
mobile/api/mail/messagecompose.h
<https://git.reviewboard.kde.org/r/118608/#comment41482>
How do you handle multiple senders/recipients? I don't think that letting the UI build MIME headers is the right approach.
- Jan Kundrát
On June 7, 2014, 9:19 p.m., Abhijeet Nikam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118608/
> -----------------------------------------------------------
>
> (Updated June 7, 2014, 9:19 p.m.)
>
>
> Review request for KDEPIM and Kevin Krammer.
>
>
> Repository: kdepim
>
>
> Description
> -------
>
> Api for Creating the text Mail. I have also added the function for sending the mail. Sending the mail part is yet to be tested.
>
>
> Diffs
> -----
>
> mobile/api/mail/messagecompose.h PRE-CREATION
> mobile/api/mail/messagecompose.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/118608/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Abhijeet Nikam
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list