[Kde-pim] Review Request 118663: Outline of the receiver model

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118663/#review60234
-----------------------------------------------------------



messagecomposer/recipient/recipient.h
<https://git.reviewboard.kde.org/r/118663/#comment41971>

    space missing before closing parentheses



messagecomposer/recipient/recipient.h
<https://git.reviewboard.kde.org/r/118663/#comment41972>

    I would say move one up, e.g. group with mEmail



mobile/api/mail/folderlist.h
<https://git.reviewboard.kde.org/r/118663/#comment41973>

    while this is a correct fix, I don't think it should be in this commit.
    It is not related at all



mobile/api/mail/receivermodel.h
<https://git.reviewboard.kde.org/r/118663/#comment41974>

    indentation



mobile/api/mail/receivermodel.h
<https://git.reviewboard.kde.org/r/118663/#comment41975>

    I don't think you'll need that, the include for recipient.h should already take care of this



mobile/api/mail/receivermodel.h
<https://git.reviewboard.kde.org/r/118663/#comment41978>

    no public data, data members start with m then uppercase first character



mobile/api/mail/receivermodel.h
<https://git.reviewboard.kde.org/r/118663/#comment41976>

    stray empty line



mobile/api/mail/receivermodel.h
<https://git.reviewboard.kde.org/r/118663/#comment41979>

    inconsistent spacing with rest of the methods



mobile/api/mail/receivermodel.h
<https://git.reviewboard.kde.org/r/118663/#comment41980>

    check if other classes using that type pass it by const reference



mobile/api/mail/receivermodel.h
<https://git.reviewboard.kde.org/r/118663/#comment41977>

    unneeded empty sections



mobile/api/mail/receivermodel.cpp
<https://git.reviewboard.kde.org/r/118663/#comment41981>

    no default value in cpp file. this usually trtiggers a compiler warning



mobile/api/mail/receivermodel.cpp
<https://git.reviewboard.kde.org/r/118663/#comment41982>

    space after keyword



mobile/api/mail/receivermodel.cpp
<https://git.reviewboard.kde.org/r/118663/#comment41983>

    always block braces in KDEPIM code



mobile/api/mail/receivermodel.cpp
<https://git.reviewboard.kde.org/r/118663/#comment41984>

    block brace on line of condition in KDEPIM code



mobile/api/mail/receivermodel.cpp
<https://git.reviewboard.kde.org/r/118663/#comment41985>

    stray second semicolon



mobile/api/mail/receivermodel.cpp
<https://git.reviewboard.kde.org/r/118663/#comment41986>

    const int.
    maybe also use that in data()?



mobile/api/mail/receivermodel.cpp
<https://git.reviewboard.kde.org/r/118663/#comment41987>

    where does "part" come from?



mobile/api/mail/receivermodel.cpp
<https://git.reviewboard.kde.org/r/118663/#comment41988>

    what if recipient is not in the list?



mobile/api/mail/receivermodel.cpp
<https://git.reviewboard.kde.org/r/118663/#comment41989>

    why is this needed? I.e. why is the next function not sufficient?



mobile/api/mail/receivermodel.cpp
<https://git.reviewboard.kde.org/r/118663/#comment41990>

    identation


- Kevin Krammer


On June 15, 2014, 6:53 a.m., Abhijeet Nikam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118663/
> -----------------------------------------------------------
> 
> (Updated June 15, 2014, 6:53 a.m.)
> 
> 
> Review request for KDEPIM, Kevin Krammer and Michael Bohlender.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> These is the basic outline of my receiver model, I wanted to have a review of this before further implementing the .cpp file.
> 
> 
> Diffs
> -----
> 
>   messagecomposer/recipient/recipient.h 0eea70b 
>   messagecomposer/recipient/recipient.cpp 3a63625 
>   mobile/api/mail/CMakeLists.txt 9fceb28 
>   mobile/api/mail/folderlist.h 06f92f2 
>   mobile/api/mail/receivermodel.h PRE-CREATION 
>   mobile/api/mail/receivermodel.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118663/diff/
> 
> 
> Testing
> -------
> 
> Compiles without any errors.
> 
> 
> Thanks,
> 
> Abhijeet Nikam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/