[Kde-pim] Review Request 118663: Outline of the receiver model

[Michael Bohlender]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118663/#review60119
-----------------------------------------------------------


Just compiling is not enought testing. It is your responsibility that your code works. The reviews will not catch every mistake every time. Reviewers usually do not test the code but just look if it makes sense.
I asked you to create the qml mockup for a reason. You can use it to test your implementation.

- Michael Bohlender


On June 15, 2014, 6:53 a.m., Abhijeet Nikam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118663/
> -----------------------------------------------------------
> 
> (Updated June 15, 2014, 6:53 a.m.)
> 
> 
> Review request for KDEPIM, Kevin Krammer and Michael Bohlender.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> These is the basic outline of my receiver model, I wanted to have a review of this before further implementing the .cpp file.
> 
> 
> Diffs
> -----
> 
>   messagecomposer/recipient/recipient.h 0eea70b 
>   messagecomposer/recipient/recipient.cpp 3a63625 
>   mobile/api/mail/CMakeLists.txt 9fceb28 
>   mobile/api/mail/folderlist.h 06f92f2 
>   mobile/api/mail/receivermodel.h PRE-CREATION 
>   mobile/api/mail/receivermodel.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118663/diff/
> 
> 
> Testing
> -------
> 
> Compiles without any errors.
> 
> 
> Thanks,
> 
> Abhijeet Nikam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/