[Kde-pim] Review Request 118663: Outline of the receiver model

[Abhijeet Nikam]

> On June 17, 2014, 12:27 p.m., Kevin Krammer wrote:
> > mobile/api/mail/receivermodel.h, line 58
> > <https://git.reviewboard.kde.org/r/118663/diff/4/?file=281352#file281352line58>
> >
> >     check if other classes using that type pass it by const reference

I checked, I didn't find any, so I didn't use the const reference.


> On June 17, 2014, 12:27 p.m., Kevin Krammer wrote:
> > mobile/api/mail/receivermodel.cpp, line 127
> > <https://git.reviewboard.kde.org/r/118663/diff/4/?file=281353#file281353line127>
> >
> >     why is this needed? I.e. why is the next function not sufficient?

It may be used in the sending part. The cc, bcc, to fields - receive it in QString in the send() code. I'll remove it if I don't need this in future while implementing the message sending code.


- Abhijeet


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118663/#review60234
-----------------------------------------------------------


On June 17, 2014, 4:09 p.m., Abhijeet Nikam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118663/
> -----------------------------------------------------------
> 
> (Updated June 17, 2014, 4:09 p.m.)
> 
> 
> Review request for KDEPIM, Kevin Krammer and Michael Bohlender.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> These is the basic outline of my receiver model, I wanted to have a review of this before further implementing the .cpp file.
> 
> 
> Diffs
> -----
> 
>   messagecomposer/recipient/recipient.h 0eea70b 
>   messagecomposer/recipient/recipient.cpp 3a63625 
>   mobile/api/mail/CMakeLists.txt 9fceb28 
>   mobile/api/mail/folderlist.h 06f92f2 
>   mobile/api/mail/mailplugin.cpp 51379e1 
>   mobile/api/mail/receivermodel.h PRE-CREATION 
>   mobile/api/mail/receivermodel.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118663/diff/
> 
> 
> Testing
> -------
> 
> Compiles without any errors.
> 
> 
> Thanks,
> 
> Abhijeet Nikam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/