[Kde-pim] Review Request 111593: Make REMOTEID optional in FETCH responses.

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111593/
-----------------------------------------------------------

(Updated July 21, 2013, 10:40 a.m.)


Status
------

This change has been marked as submitted.


Review request for Akonadi and Dan Vrátil.


Description
-------

Rather large diff since I needed to restructure FetchHelper a bit to make the changed parts easier to unit-test.

RID just like any other optional property is still queried from the DB, that's a follow-up fix.


Diffs
-----

  asapcat/tests/kmail-4.12-folder-listing.asap PRE-CREATION 
  libs/protocol_p.h 7ee6511 
  server/src/handler/fetchhelper.h 4ad00f9 
  server/src/handler/fetchhelper.cpp 1236e51 
  server/tests/unittest/CMakeLists.txt 516e64d 
  server/tests/unittest/fetchhelpertest.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/111593/diff/


Testing
-------

Unit-test & using KMail. The asapcat test case shows a 5% decrease in transfer volume.


Thanks,

Volker Krause

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/