[Kde-pim] Review Request 111619: Minimize queried data in the FETCH handler

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111619/#review36235
-----------------------------------------------------------


This review has been submitted with commit 1d423852db34ea85bd6e0991d59d435e6ff4d9d3 by Volker Krause to branch master.

- Commit Hook


On July 20, 2013, 3:05 p.m., Volker Krause wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111619/
> -----------------------------------------------------------
> 
> (Updated July 20, 2013, 3:05 p.m.)
> 
> 
> Review request for Akonadi and Dan Vrátil.
> 
> 
> Description
> -------
> 
> We were querying a bunch of columns that were either never used, or only used with specific command options. Now we are only querying what is actually used.
> 
> 
> Git Log:
> 
> 
> Remove to unused JOINs.
> 
> Speeds up FETCH by another ~10%.
> 
> 
> Only query columns we are actually going to use.
> 
> Speeds up the KMail folder listing test case by about 10-20%.
> 
> 
> Add item query column mapping.
> 
> 
> Factor out item query result extraction.
> 
> This prepares a more sophisticated column selection in the query, to avoid
> loading data we don't need at all.
> 
> 
> Diffs
> -----
> 
>   server/src/handler/fetchhelper.h 4ad00f9e9f16ddbbfcca94998a533f27046748cc 
>   server/src/handler/fetchhelper.cpp 85227cba584c1f8640588fc0d4575a6066a8167c 
> 
> Diff: http://git.reviewboard.kde.org/r/111619/diff/
> 
> 
> Testing
> -------
> 
> unit tests, using KMail
> 
> also testing the post-review command :)
> 
> 
> Thanks,
> 
> Volker Krause
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/