[Kde-pim] Review Request 111593: Make REMOTEID optional in FETCH responses.

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111593/#review36221
-----------------------------------------------------------

Ship it!


Nice, thanks!


server/tests/unittest/fetchhelpertest.cpp
<http://git.reviewboard.kde.org/r/111593/#comment26807>

    Don't live in the past :)


- Dan Vrátil


On July 19, 2013, 11:35 a.m., Volker Krause wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111593/
> -----------------------------------------------------------
> 
> (Updated July 19, 2013, 11:35 a.m.)
> 
> 
> Review request for Akonadi and Dan Vrátil.
> 
> 
> Description
> -------
> 
> Rather large diff since I needed to restructure FetchHelper a bit to make the changed parts easier to unit-test.
> 
> RID just like any other optional property is still queried from the DB, that's a follow-up fix.
> 
> 
> Diffs
> -----
> 
>   asapcat/tests/kmail-4.12-folder-listing.asap PRE-CREATION 
>   libs/protocol_p.h 7ee6511 
>   server/src/handler/fetchhelper.h 4ad00f9 
>   server/src/handler/fetchhelper.cpp 1236e51 
>   server/tests/unittest/CMakeLists.txt 516e64d 
>   server/tests/unittest/fetchhelpertest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111593/diff/
> 
> 
> Testing
> -------
> 
> Unit-test & using KMail. The asapcat test case shows a 5% decrease in transfer volume.
> 
> 
> Thanks,
> 
> Volker Krause
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/